fix: only ping k8s for healthz in podsubnet #3616
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the healthz handler to only include Kubernetes API server connectivity checks in dynamic podsubnet mode, reducing unnecessary checks in static modes. Key changes include:
- Modifying the main service to conditionally enable the API server ping based on the podsubnet mode.
- Updating tests to reflect the new Config struct in the healthz package.
- Refactoring the healthz handler to use a new configuration structure with a single PingAPIServer flag.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| cns/service/main.go | Updated healthz handler initialization to use conditional API ping. |
| cns/healthserver/healthz_test.go | Updated tests to use the new Config struct with the PingAPIServer flag. |
| cns/healthserver/healthz.go | Refactored the NewHealthzHandlerWithChecks function to use the new config. |
Comments suppressed due to low confidence (2)
cns/healthserver/healthz.go:22
- [nitpick] The new struct name 'Config' is quite generic; consider renaming it to 'HealthzConfig' to provide clearer context.
type Config struct {
cns/healthserver/healthz.go:30
- Avoid shadowing the input 'cfg' by using a different variable name (e.g., 'kubeCfg') when obtaining the kubeconfig to improve code clarity.
cfg, err := ctrl.GetConfig()
Collaborator
Author
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
rbtr
force-pushed
the
fix/healthz-ping-podsubnet
branch
2 times, most recently
from
7fef88b to
35c0c96
Compare
Signed-off-by: GitHub <[email protected]>
rbtr
force-pushed
the
fix/healthz-ping-podsubnet
branch
from
4290f92 to
43a0746
Compare
Collaborator
Author
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
QxBytes
approved these changes
Apr 30, 2025
Signed-off-by: GitHub <[email protected]>
rbtr
force-pushed
the
fix/healthz-ping-podsubnet
branch
from
43a0746 to
6e3ad3d
Compare
santhoshmprabhu
approved these changes
May 1, 2025
Collaborator
Author
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
sivakami-projects
pushed a commit
that referenced
this pull request
Oct 23, 2025
* fix: only ping k8s for healthz in podsubnet Signed-off-by: GitHub <[email protected]> * update dockerfiles Signed-off-by: GitHub <[email protected]> --------- Signed-off-by: GitHub <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only really need an ongoing connection to k8s if we are in dynamic podsubnet mode. Overlay and vnetblock are static and do not need it after initialization, so we shouldn't consider loss of apiserver connectivity a restartable failure in those scenarios.